Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIU-3179] Add ability to create/edit role assignments for all of a user's affiliations #2851

Merged
merged 10 commits into from
Feb 7, 2025

Conversation

ryandberger
Copy link
Member

@ryandberger ryandberger commented Jan 31, 2025

  • Fulfills UIU-3179.
  • Add the Tenant Select dropdown in User Edit screen. When changing tenant, you can add/remove roles for that user's affiliated tenant.
  • When tenant is changed, this is tracked in state and API calls are re-run to get that tenant's role IDs and role definitions.
  • The object used with Final Form switches from [roleId] to {tenantId1: [roleId], tenantId2: [roleId]} in order to remember changes made to multiple tenants when saving. This also allows for {tenantId1: [roleId], tenantId2: []} which would remove all roles from tenant2.
image

@ryandberger ryandberger requested review from zburke and aidynoJ January 31, 2025 20:08
@aidynoJ
Copy link
Contributor

aidynoJ commented Feb 4, 2025

LGTM!

@ryandberger ryandberger marked this pull request as ready for review February 5, 2025 15:33
Copy link

github-actions bot commented Feb 7, 2025

Jest Unit Test Results

    1 files  ±0    263 suites  ±0   4m 36s ⏱️ -1s
1 205 tests ±0  1 202 ✅ ±0  3 💤 ±0  0 ❌ ±0 
1 246 runs  ±0  1 243 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 3993f25. ± Comparison against base commit 92f5a4a.

♻️ This comment has been updated with latest results.

@folio-org folio-org deleted a comment from sonarqubecloud bot Feb 7, 2025
@ryandberger ryandberger merged commit 2984439 into master Feb 7, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants